From cdbf91526f7299cbbf6d3d2905f5b68aeb53d2f6 Mon Sep 17 00:00:00 2001 From: SJCoetz Date: Thu, 30 Jul 2026 22:19:21 +0200 Subject: [PATCH] refactor(stock-quick-draft): useState lazy init, sr-only title, trim mock stubs Co-authored-by: Orca --- src/components/stock-orders/quick-draft-modal.test.tsx | 3 --- src/components/stock-orders/quick-draft-modal.tsx | 9 +++------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/components/stock-orders/quick-draft-modal.test.tsx b/src/components/stock-orders/quick-draft-modal.test.tsx index d0af3a1..9ecf66c 100644 --- a/src/components/stock-orders/quick-draft-modal.test.tsx +++ b/src/components/stock-orders/quick-draft-modal.test.tsx @@ -9,9 +9,6 @@ vi.mock("@/components/ui/modal-shell", () => ({ ModalShell: { Dialog: ({ children, open }: { children: React.ReactNode; open: boolean }) => open ?
{children}
: null, - Header: ({ children }: { children: React.ReactNode }) =>
{children}
, - Body: ({ children }: { children: React.ReactNode }) =>
{children}
, - Footer: ({ children }: { children: React.ReactNode }) =>
{children}
, }, })); diff --git a/src/components/stock-orders/quick-draft-modal.tsx b/src/components/stock-orders/quick-draft-modal.tsx index 4f97583..77df9d0 100644 --- a/src/components/stock-orders/quick-draft-modal.tsx +++ b/src/components/stock-orders/quick-draft-modal.tsx @@ -1,6 +1,6 @@ "use client"; -import { useMemo } from "react"; +import { useState } from "react"; import { Input } from "@/components/ui/input"; import { ModalShell } from "@/components/ui/modal-shell"; @@ -34,11 +34,8 @@ function formatMonthYear(date: Date): string { } export function QuickDraftModal({ open, onOpenChange }: QuickDraftModalProps) { - const defaultReference = useMemo( + const [defaultReference] = useState( () => `Stock order entry — ${formatMonthYear(new Date())}`, - // intentionally only computed once per mount - // eslint-disable-next-line react-hooks/exhaustive-deps - [], ); return ( @@ -47,7 +44,7 @@ export function QuickDraftModal({ open, onOpenChange }: QuickDraftModalProps) { onOpenChange={onOpenChange} size="xl" eyebrow="Stock Order Reference" - title="" + title={Stock Order Reference} footer={