From a4bfef123ba73a148a7353e9f699efccd7195769 Mon Sep 17 00:00:00 2001
From: Claude <claude@anthropic.com>
Date: Mon, 31 Aug 2026 16:56:03 +0200
Subject: [PATCH] fix(stock): return 400 (not 500) for malformed PB id in
 set-pricing route
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Code-review feedback from Task 4: the verbatim plan source had a
`throw new Error(...)` inside the per-row .map() that escaped
synchronously as an HTTP 500 instead of the structured 400 envelope
the rest of the route uses for validation errors. Swap .map() for a
for-of loop that returns the structured 400.

Verified:
- Bad id → 400 {code: "validation_error", ...}
- Happy path → 200 unchanged
---
 .../api/v1/stock/items/set-pricing/route.ts   | 23 +++++++++++++++----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/src/app/api/v1/stock/items/set-pricing/route.ts b/src/app/api/v1/stock/items/set-pricing/route.ts
index 47d410d..37ec318 100644
--- a/src/app/api/v1/stock/items/set-pricing/route.ts
+++ b/src/app/api/v1/stock/items/set-pricing/route.ts
@@ -44,9 +44,22 @@ export async function POST(req: Request) {
     );
   }
 
-  const updates = body.updates.map((u, i) => {
-    if (typeof u.id !== "string" || !PB_ID_RE.test(u.id)) {
-      throw new Error(`updates[${i}].id must be a 15-char PB id`);
+  const updates: Array<{
+    id: string;
+    costPrice?: number;
+    sellingPrice?: number;
+    markup?: number;
+  }> = [];
+  for (let i = 0; i < body.updates.length; i++) {
+    const u = body.updates[i];
+    if (!u || typeof u.id !== "string" || !PB_ID_RE.test(u.id)) {
+      return NextResponse.json(
+        {
+          code: "validation_error",
+          message: `updates[${i}].id must be a 15-char PB id`,
+        },
+        { status: 400 },
+      );
     }
     const out: { id: string; costPrice?: number; sellingPrice?: number; markup?: number } = {
       id: u.id,
@@ -54,8 +67,8 @@ export async function POST(req: Request) {
     if (u.costPrice !== undefined) out.costPrice = Number(u.costPrice);
     if (u.sellingPrice !== undefined) out.sellingPrice = Number(u.sellingPrice);
     if (u.markup !== undefined) out.markup = Number(u.markup);
-    return out;
-  });
+    updates.push(out);
+  }
 
   let pb;
   try {