HERMES-GIELIE/static
Nathan Esquenazi 574cd2cf70 fix(review): 5 issues found in agent review of PR #40
BUG-1 (critical): CSS cascade — .sidebar{position:relative} and
.rightpanel{position:relative} at line 528/530 appeared after the
@media(max-width:640px) block and silently overrode the position:fixed
overlay behavior needed for the mobile slide-in. Wrapped both in
@media(min-width:641px) so they only apply on desktop.

BUG-2 (medium): mobileSwitchPanel() in boot.js always reopened the
sidebar overlay after closing it, with a stale comment saying 'close
after a moment' but no actual auto-close. For the 'chat' panel, the
content lives in the main area — reopening the sidebar obstructs it.
Fixed: only open sidebar for non-chat panels; chat tap closes sidebar.

BUG-3 (medium): Dockerfile was missing 'pip install -r requirements.txt'.
pyyaml (required by api/config.py) is not in the python:3.12-slim base
image — the container would fail at startup with ImportError.

SEC-2 (medium): No .dockerignore — COPY . /app included .git/, tests/,
and .env* in every image. Added .dockerignore excluding these.

NIT-3: docker-compose.yml used ${HERMES_HOME:-~/.hermes} but Docker
Compose does not shell-expand ~ in default values. Changed to
${HERMES_HOME:-${HOME}/.hermes}.

Tests: 415 passed, 0 failed (same as pre-fix).
2026-04-03 17:21:42 +00:00
..
boot.js fix(review): 5 issues found in agent review of PR #40 2026-04-03 17:21:42 +00:00
commands.js feat: Sprint 17 -- workspace breadcrumbs, slash commands, send key setting 2026-04-03 04:13:38 -07:00
index.html feat: Sprint 21 — mobile responsive layout + Docker support 2026-04-03 10:09:36 -07:00
messages.js feat: polish send button — hidden until content, icon-circle, pop-in animation 2026-04-03 07:20:16 -07:00
panels.js fix(auth): blank password field no longer clears auth; add Disable Auth button 2026-04-03 06:21:04 -07:00
sessions.js feat: Sprint 21 — mobile responsive layout + Docker support 2026-04-03 10:09:36 -07:00
style.css fix(review): 5 issues found in agent review of PR #40 2026-04-03 17:21:42 +00:00
ui.js feat: polish send button — hidden until content, icon-circle, pop-in animation 2026-04-03 07:20:16 -07:00
workspace.js fix: apply review fixes, update version to v0.20, add Sprint 18 changelog 2026-04-03 05:02:30 -07:00