The #4720 done-handler comment (9 lines) pushed the tab-anchor localStorage sync (`hermes-webui-session` setItem + _setActiveSessionUrl) past the 800-char proximity window that test_session_rotate_url_sync asserts the #3018 session-id sync lives within — so the PR's `test (3.x, 2)` shards were failing on master's own regression guard. The full pytest suite caught it; the PR's gate slice did not run it. Fix (behavior unchanged — the _oldestIdx reset stays in the same place, before the re-filter, guarded): - Trim the inline comment to one line (the full rationale is in the #4720 commit + issue), so the completion block stops overflowing the guard window. - The reset statement legitimately grew the completion block even bare, so widen test_session_rotate_url_sync's proximity window 800 -> 1000 (still well within the single done/settled handler; the guard's intent is preserved). test_session_rotate_url_sync + test_issue4720_* both pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| vendor | ||
| apple-touch-icon.png | ||
| assistant_turn_anchors.js | ||
| boot.js | ||
| commands.js | ||
| favicon-32.png | ||
| favicon-192.png | ||
| favicon-512.png | ||
| favicon-512.svg | ||
| favicon.ico | ||
| favicon.svg | ||
| i18n.js | ||
| icons.js | ||
| index.html | ||
| login.js | ||
| manifest.json | ||
| messages.js | ||
| onboarding.js | ||
| outline.js | ||
| panels.js | ||
| pwa-startup.js | ||
| sessions.js | ||
| style.css | ||
| sw.js | ||
| terminal.js | ||
| ui.js | ||
| workspace.js | ||