David/HERMES-GIELIE
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: cover context-selection counter reset on clear/session-switch (#5929)

Browse source 
Adds regression coverage for the akay64 fix: _selectionIdCounter must reset to 0
when the last chip is removed (_removeNamedContextBlock) and on
_clearPendingSelections, so context chips restart at 'Context 1' after a
clear-all or session switch instead of continuing at 'Context N+1'.

Co-authored-by: akay64 <akay64@users.noreply.github.com>
This commit is contained in:
nesquena-hermes 2026-07-11 07:47:25 +00:00
parent cd69de50a9
commit e0dea16940
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tests/test_issue2543_named_context_session_switch.py
View file

@ -34,3 +34,24 @@ def test_newsession_clears_pending_named_context():
assert "window._clearPendingSelections()" in head, (
"newSession() must clear pending named context blocks before replacing S.session"
)
def test_selection_id_counter_resets_when_all_chips_cleared():
# #5929: the module-level _selectionIdCounter only ever incremented, so
# clearing all context chips and selecting again started at "Context N+1"
# instead of "Context 1". It must reset to 0 when the last chip is removed
# AND on _clearPendingSelections (clear-all / session switch).
remove_fn = MESSAGES_JS[
MESSAGES_JS.index("function _removeNamedContextBlock(id){"):
MESSAGES_JS.index("function _clearPendingSelections(){")
]
assert "if(!_pendingSelections.length)_selectionIdCounter=0;" in remove_fn, (
"_removeNamedContextBlock must reset _selectionIdCounter to 0 once the "
"last chip is removed so the next selection restarts at Context 1"
)
clear_fn = MESSAGES_JS[MESSAGES_JS.index("function _clearPendingSelections(){"):]
clear_fn = clear_fn[:clear_fn.index("\n}") + 2]
assert "_selectionIdCounter=0;" in clear_fn, (
"_clearPendingSelections must reset _selectionIdCounter to 0 (clear-all "
"and session-switch path) so context chip numbering restarts at 1"
)