Merge pull request #4189 from nesquena/stage-na

Release OA (v0.51.414): fix misleading regenerate-title error message (#4186)
This commit is contained in:
nesquena-hermes 2026-06-14 11:08:19 -07:00 committed by GitHub
commit d7c8a0c780
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 2 deletions

View file

@ -3,6 +3,12 @@
## [Unreleased]
## [v0.51.414] — 2026-06-14 — Release OA (fix misleading regenerate-title error message, #4186)
### Fixed
- **The read-only error for the regenerate-title action now reads correctly.** Attempting to regenerate a title on a read-only imported session returned "Read-only imported sessions cannot be renamed" (copy-pasted from the rename handler); it now says "cannot regenerate titles" to match the actual action. (#4186)
## [v0.51.413] — 2026-06-14 — Release NZ (restore approval pending-fallback reliability, #4107)
### Fixed

View file

@ -7756,7 +7756,7 @@ def handle_post(handler, parsed) -> bool:
except KeyError:
return bad(handler, "Session not found", 404)
except PermissionError:
return bad(handler, "Read-only imported sessions cannot be renamed", 403)
return bad(handler, "Read-only imported sessions cannot regenerate titles", 403)
next_title, reason, raw_preview = generate_session_title_for_session(s, prefer_latest=prefer_latest)
if not next_title:
return bad(handler, f"Could not generate a better title ({reason or 'empty'})", 422)

View file

@ -55,7 +55,7 @@ def test_regenerate_endpoint_persists_generated_title_without_reordering_sidebar
block = ROUTES_PY[endpoint_idx:next_endpoint_idx]
assert "generate_session_title_for_session" in block
assert '_persist_generated_session_title(s, next_title, event_reason="session_title_regenerate")' in block
assert "Read-only imported sessions cannot be renamed" in block
assert "Read-only imported sessions cannot regenerate titles" in block
def test_regenerate_helper_persists_generated_title_and_publishes_sidebar_refresh():