David/HERMES-GIELIE
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: deduplicate clone name + explicit enabled:false for duplicates

Browse source 
- Name dedup: 'Job (copy)', 'Job (copy 2)', 'Job (copy 3)' etc.
- Duplicates explicitly pass enabled:false to backend
- Normal cron create is unaffected (no enabled field sent)

Addresses reviewer feedback on #1225 (points 1 + 4).
This commit is contained in:
bergeouss 2026-04-28 12:59:39 +00:00 committed by Hermes Agent
parent 8c63324ff7
commit d08d96f864
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
static/panels.js
View file

@ -466,8 +466,19 @@ function duplicateCurrentCron(){
_cronPreFormDetail = { ...job };
_editingCronId = null;
_cronMode = 'create';
_cronIsDuplicate = true;
_cronSelectedSkills = Array.isArray(job.skills) ? [...job.skills] : [];
const dupName = job.name ? job.name + ' (copy)' : '';
// Deduplicate name: append "(copy)", "(copy 2)", "(copy 3)" etc.
const baseName = job.name || '';
let dupName = baseName + ' (copy)';
if (_cronList && _cronList.length) {
const taken = new Set(_cronList.filter(j => j.name).map(j => j.name));
if (taken.has(dupName)) {
let n = 2;
while (taken.has(baseName + ' (copy ' + n + ')')) n++;
dupName = baseName + ' (copy ' + n + ')';
}
}
_renderCronForm({
name: dupName,
schedule: job.schedule_display || (job.schedule && job.schedule.expression) || '',
@ -495,6 +506,7 @@ async function deleteCurrentCron(){
}
let _cronSelectedSkills=[];
let _cronIsDuplicate = false;
let _cronSkillsCache=null;
function openCronCreate(){
@ -502,6 +514,7 @@ function openCronCreate(){
_cronPreFormDetail = _currentCronDetail ? { ..._currentCronDetail } : null;
_editingCronId = null;
_cronMode = 'create';
_cronIsDuplicate = false;
_cronSelectedSkills = [];
_renderCronForm({ name:'', schedule:'', prompt:'', deliver:'local', isEdit:false });
_cronSkillsCache = null;
@ -667,10 +680,12 @@ async function saveCronForm(){
return;
}
const body={schedule,prompt,deliver};
if(_cronIsDuplicate) body.enabled=false;
if(name)body.name=name;
if(_cronSelectedSkills.length)body.skills=_cronSelectedSkills;
const res = await api('/api/crons/create',{method:'POST',body:JSON.stringify(body)});
_cronPreFormDetail = null;
_cronIsDuplicate = false;
showToast(t('cron_job_created'));
await loadCrons();
const newId = res && (res.id || (res.job && res.job.id));