David/HERMES-GIELIE
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: guard finalizeThinkingCard with session ID check (#1366)

Browse source 
Without this check, switching browser tabs while a stream is running
causes finalizeThinkingCard() to operate on the wrong session's
thinking card DOM — the card belongs to the stream that started it,
not the session currently displayed in the tab. The guard ensures
finalize only runs when the live assistant turn's session matches
the current session.

Co-authored-by: Josh <josh@fyul.link>
This commit is contained in:
Josh 2026-04-30 22:25:25 +00:00 committed by nesquena-hermes
parent 2566b434d1
commit d0257e8bcf
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
static/ui.js
View file

@ -4275,6 +4275,12 @@ function _thinkingMarkup(text=''){
: `<div class="thinking"><div class="dot"></div><div class="dot"></div><div class="dot"></div></div>`;
}
function finalizeThinkingCard(){
// Guard: only finalize thinking card if we're looking at the session that started it.
// Without this check, switching tabs while a stream is running causes finalizeThinkingCard
// to remove/modify the thinking card DOM of the wrong session — the card belongs to the
// stream that started it, not the session currently displayed.
const _guardTurn = $('liveAssistantTurn');
if(_guardTurn && S.session && _guardTurn.dataset.sessionId !== S.session.session_id) return;
if(!isSimplifiedToolCalling()){
const row=$('thinkingRow');
if(!row) return;