David/HERMES-GIELIE
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix misleading error message in regenerate-title endpoint

Browse source
This commit is contained in:
Rod Boev 2026-06-14 13:50:38 -04:00
parent b983a57dc3
commit 43ec609772
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
api/routes.py
View file

@ -7754,7 +7754,7 @@ def handle_post(handler, parsed) -> bool:
except KeyError:
return bad(handler, "Session not found", 404)
except PermissionError:
return bad(handler, "Read-only imported sessions cannot be renamed", 403)
return bad(handler, "Read-only imported sessions cannot regenerate titles", 403)
next_title, reason, raw_preview = generate_session_title_for_session(s, prefer_latest=prefer_latest)
if not next_title:
return bad(handler, f"Could not generate a better title ({reason or 'empty'})", 422)

2
tests/test_session_title_regenerate_controls.py
View file

@ -55,7 +55,7 @@ def test_regenerate_endpoint_persists_generated_title_without_reordering_sidebar
block = ROUTES_PY[endpoint_idx:next_endpoint_idx]
assert "generate_session_title_for_session" in block
assert '_persist_generated_session_title(s, next_title, event_reason="session_title_regenerate")' in block
assert "Read-only imported sessions cannot be renamed" in block
assert "Read-only imported sessions cannot regenerate titles" in block
def test_regenerate_helper_persists_generated_title_and_publishes_sidebar_refresh():