fix(auth): persist sessions across restarts via STATE_DIR/.sessions.json (#962)
_sessions is an in-memory dict, so every process restart (launchd bounce,
systemd restart, container recycle) invalidates all active browser sessions.
Users get 401 on every authenticated endpoint until they clear cookies.
The HMAC signing key already persists to STATE_DIR/.signing_key via atomic
owner-only write. This PR applies the same pattern to the session table:
- _load_sessions(): reads .sessions.json on module import, prunes expired
entries, tolerates missing/malformed files (returns {} on any error)
- _save_sessions(): atomic write via tempfile + os.replace(), chmod 0600,
mirrors .signing_key write pattern exactly
- create_session(): saves after inserting new token
- invalidate_session(): saves after removing token (only if token existed)
- _prune_expired_sessions(): saves only when entries are actually removed
Cookie format and signing are unchanged; existing sessions survive upgrade.
6 regression tests cover: restart survival, invalidation persistence,
expiry pruning on load, 0600 permissions, corrupt-file tolerance.
Co-authored with Claude Sonnet 4.6 / Anthropic.
2026-04-24 18:21:41 +00:00
|
|
|
"""Regression tests: auth sessions persist across process restarts.
|
|
|
|
|
|
|
|
|
|
_sessions is an in-memory dict. Without persistence, any restart (launchd,
|
|
|
|
|
systemd, container) invalidates all active browser sessions and floods clients
|
|
|
|
|
with 401s until they clear cookies. The HMAC signing key already persists to
|
|
|
|
|
STATE_DIR; this PR persists the session table using the same pattern.
|
|
|
|
|
"""
|
|
|
|
|
import importlib
|
|
|
|
|
import json
|
|
|
|
|
import os
|
|
|
|
|
import sys
|
|
|
|
|
import tempfile
|
|
|
|
|
import time
|
|
|
|
|
import unittest
|
|
|
|
|
from pathlib import Path
|
|
|
|
|
|
|
|
|
|
# Isolate state dir so tests never touch real sessions
|
|
|
|
|
_TEST_STATE = Path(tempfile.mkdtemp())
|
|
|
|
|
os.environ["HERMES_WEBUI_STATE_DIR"] = str(_TEST_STATE)
|
|
|
|
|
|
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent.parent))
|
|
|
|
|
|
|
|
|
|
import api.auth as auth
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
class TestSessionPersistence(unittest.TestCase):
|
|
|
|
|
"""Sessions survive a simulated process restart (module reload)."""
|
|
|
|
|
|
|
|
|
|
def setUp(self) -> None:
|
|
|
|
|
auth._sessions.clear()
|
|
|
|
|
sessions_file = _TEST_STATE / '.sessions.json'
|
|
|
|
|
if sessions_file.exists():
|
|
|
|
|
sessions_file.unlink()
|
|
|
|
|
|
|
|
|
|
def _simulate_restart(self) -> None:
|
v0.50.211: compact timestamps, adaptive title refresh, settings picker fix (#1061)
* Shorten session sidebar relative time labels
* feat: adaptive session title refresh based on conversation evolution
Addresses #869 — the 'Optional' part: adapt session names to current
conversation context instead of only generating once from the first exchange.
Backend (api/streaming.py):
- Add _latest_exchange_snippets() to extract last user+assistant pair
- Add _count_exchanges() to count user messages
- Add _get_title_refresh_interval() to read the setting
- Add _run_background_title_refresh() — refreshes title from latest exchange
with LLM, skips if title is unchanged or user manually renamed
- Add _maybe_schedule_title_refresh() — checks exchange count and schedules
refresh after stream_end (non-blocking)
Config (api/config.py):
- Add auto_title_refresh_every setting (default '0' = off)
- Enum validation: {'0', '5', '10', '20'}
Frontend:
- Settings UI dropdown (static/index.html)
- Wire up load/save in panels.js
- i18n keys for all 6 locales (en/ru/es/de/zh/zh-Hant)
Default: off. Opt-in via Settings > Conversation > Adaptive title refresh.
* test: add 37 tests for adaptive title refresh helpers
Covers all five new functions introduced in this PR:
_count_exchanges, _latest_exchange_snippets, _get_title_refresh_interval,
_run_background_title_refresh, _maybe_schedule_title_refresh
Co-authored-by: bergeouss <bergeouss@users.noreply.github.com>
* fix(settings): show selected state on theme/skin/font-size picker cards
The CSS rule `#mainSettings .theme-pick-btn { border-color: var(--border) !important }` was
overriding the inline `style.borderColor = "var(--accent)"` set by `_syncThemePicker()` and
siblings — `!important` beats inline styles. Active cards showed no visual highlight.
Fix: move to `.active` CSS class with `border-color:var(--accent)!important` so the active
rule wins over the base rule, and clear the stale inline borderColor/boxShadow from the
sync functions. 5 regression tests added.
Closes #1057
* fix: rename test file to match PR number, fix stale issue reference
* docs: v0.50.211 release notes and version bump
Compact sidebar timestamps, adaptive title refresh (opt-in), settings picker fix.
* docs(changelog): correct settings tab for adaptive title refresh
The v0.50.211 entry for #1058 said "Settings → Appearance" but the
toggle is actually rendered inside settingsPanePreferences (the
Preferences tab) per static/index.html:604+. The commit message also
had the wrong tab ("Conversation"). Updated CHANGELOG to match the
actual UI surface so users can find the toggle.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: create state dir before writing settings file
save_settings() called SETTINGS_FILE.write_text() without ensuring the
parent directory exists. In fresh environments (CI, first run without
HERMES_WEBUI_STATE_DIR set) this raised FileNotFoundError.
Add mkdir(parents=True, exist_ok=True) before the write.
---------
Co-authored-by: Pavol Biely <biely@webtec.sk>
Co-authored-by: bergeouss <bergeouss@users.noreply.github.com>
Co-authored-by: nesquena-hermes <nesquena-hermes@users.noreply.github.com>
Co-authored-by: Nathan Esquenazi <nesquena@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-26 00:50:58 +00:00
|
|
|
"""Reload auth module to simulate a fresh process start.
|
|
|
|
|
|
|
|
|
|
api.auth does `from api.config import STATE_DIR` at module level, so
|
|
|
|
|
`_SESSIONS_FILE` is computed from api.config.STATE_DIR at reload time.
|
|
|
|
|
We temporarily override api.config.STATE_DIR so the reload uses the
|
|
|
|
|
test state dir without reloading api.config itself (which would
|
|
|
|
|
invalidate imported references like STREAM_PARTIAL_TEXT in other tests).
|
|
|
|
|
"""
|
|
|
|
|
import api.config as _config
|
|
|
|
|
_saved = _config.STATE_DIR
|
|
|
|
|
_config.STATE_DIR = _TEST_STATE
|
|
|
|
|
try:
|
|
|
|
|
importlib.reload(auth)
|
|
|
|
|
finally:
|
|
|
|
|
_config.STATE_DIR = _saved
|
fix(auth): persist sessions across restarts via STATE_DIR/.sessions.json (#962)
_sessions is an in-memory dict, so every process restart (launchd bounce,
systemd restart, container recycle) invalidates all active browser sessions.
Users get 401 on every authenticated endpoint until they clear cookies.
The HMAC signing key already persists to STATE_DIR/.signing_key via atomic
owner-only write. This PR applies the same pattern to the session table:
- _load_sessions(): reads .sessions.json on module import, prunes expired
entries, tolerates missing/malformed files (returns {} on any error)
- _save_sessions(): atomic write via tempfile + os.replace(), chmod 0600,
mirrors .signing_key write pattern exactly
- create_session(): saves after inserting new token
- invalidate_session(): saves after removing token (only if token existed)
- _prune_expired_sessions(): saves only when entries are actually removed
Cookie format and signing are unchanged; existing sessions survive upgrade.
6 regression tests cover: restart survival, invalidation persistence,
expiry pruning on load, 0600 permissions, corrupt-file tolerance.
Co-authored with Claude Sonnet 4.6 / Anthropic.
2026-04-24 18:21:41 +00:00
|
|
|
|
|
|
|
|
def test_session_survives_restart(self) -> None:
|
|
|
|
|
"""A session created before restart should still verify after reload."""
|
|
|
|
|
cookie = auth.create_session()
|
|
|
|
|
self.assertTrue(auth.verify_session(cookie))
|
|
|
|
|
self._simulate_restart()
|
|
|
|
|
self.assertTrue(auth.verify_session(cookie),
|
|
|
|
|
"Session must survive process restart via persisted .sessions.json")
|
|
|
|
|
|
|
|
|
|
def test_invalidated_session_does_not_survive_restart(self) -> None:
|
|
|
|
|
"""Invalidating a session must be reflected after reload."""
|
|
|
|
|
cookie = auth.create_session()
|
|
|
|
|
auth.invalidate_session(cookie)
|
|
|
|
|
self._simulate_restart()
|
|
|
|
|
self.assertFalse(auth.verify_session(cookie),
|
|
|
|
|
"Invalidated session must not be reinstated after restart")
|
|
|
|
|
|
|
|
|
|
def test_expired_sessions_pruned_on_load(self) -> None:
|
|
|
|
|
"""Sessions that expire between restarts must not be loaded."""
|
|
|
|
|
sessions_file = _TEST_STATE / '.sessions.json'
|
|
|
|
|
# Write a sessions file with one expired and one valid entry
|
|
|
|
|
now = time.time()
|
|
|
|
|
sessions_file.write_text(json.dumps({
|
|
|
|
|
"expired_token": now - 10,
|
|
|
|
|
"valid_token": now + 3600,
|
|
|
|
|
}))
|
|
|
|
|
self._simulate_restart()
|
|
|
|
|
self.assertNotIn("expired_token", auth._sessions)
|
|
|
|
|
self.assertIn("valid_token", auth._sessions)
|
|
|
|
|
|
|
|
|
|
def test_sessions_file_permissions(self) -> None:
|
|
|
|
|
"""Sessions file must be owner-read-only (0600)."""
|
|
|
|
|
auth.create_session()
|
|
|
|
|
sessions_file = _TEST_STATE / '.sessions.json'
|
|
|
|
|
self.assertTrue(sessions_file.exists(), ".sessions.json was not created")
|
|
|
|
|
mode = oct(sessions_file.stat().st_mode & 0o777)
|
|
|
|
|
self.assertEqual(mode, oct(0o600),
|
|
|
|
|
f".sessions.json permissions {mode} — expected 0o600")
|
|
|
|
|
|
|
|
|
|
def test_malformed_sessions_file_starts_fresh(self) -> None:
|
|
|
|
|
"""A corrupt sessions file must not crash auth — start with empty dict."""
|
|
|
|
|
sessions_file = _TEST_STATE / '.sessions.json'
|
|
|
|
|
sessions_file.write_text("not valid json {{{{")
|
|
|
|
|
self._simulate_restart()
|
|
|
|
|
self.assertEqual(auth._sessions, {},
|
|
|
|
|
"Corrupt sessions file must result in empty session dict")
|
|
|
|
|
|
|
|
|
|
def test_sessions_file_wrong_type_starts_fresh(self) -> None:
|
|
|
|
|
"""A sessions file containing a non-dict must be ignored."""
|
|
|
|
|
sessions_file = _TEST_STATE / '.sessions.json'
|
|
|
|
|
sessions_file.write_text(json.dumps(["list", "not", "dict"]))
|
|
|
|
|
self._simulate_restart()
|
|
|
|
|
self.assertEqual(auth._sessions, {})
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if __name__ == "__main__":
|
|
|
|
|
unittest.main()
|